Skip to content

Update ko.nav.about in ko.yml (locales) #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hahwul
Copy link

@hahwul hahwul commented Jul 31, 2025

대하여 to 소개

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Most Korean websites use "소개" for "About." I believe this translation is more user-friendly for Korean users, so I'm submitting a PR.

대하여 to 소개

Signed-off-by: HAHWUL <[email protected]>
@hahwul hahwul requested a review from a team as a code owner July 31, 2025 15:09
@hahwul hahwul temporarily deployed to Pages Preview July 31, 2025 15:09 — with GitHub Actions Inactive
@hahwul hahwul temporarily deployed to Pages Preview July 31, 2025 15:10 — with GitHub Actions Inactive
@Copilot Copilot AI review requested due to automatic review settings August 8, 2025 16:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Korean translation for the "About" navigation item from "대하여" to "소개" to better align with common Korean web conventions and improve user experience for Korean users.

  • Updates a single translation key in the Korean locale file

@@ -1,7 +1,7 @@
ko:
locale_name: 한국어
nav:
about: 대하여
about: 소개
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this change it from About to Introduction?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jmeridth
Yes, you're correct. The change shifts the term from "About" to "Introduction." I made this adjustment because the direct translation of "About" into Korean ("대하여") can feel awkward without a clear subject.

In this context, "Introduction" ("소개") feels more natural. If we were to keep "About," it might work better with an explicit subject—similar to Japanese, e.g., "このサイトについて" ("About this site"), which translates to "이 사이트에 대하여" in Korean.

What do you think about changing it to "이 사이트에 대하여"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with Introduction. Thank you very much for explaining the context. Today I learned. 🙇

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Glad we're aligned on Introduction. Thanks for the feedback. 😊

@jmeridth jmeridth added this pull request to the merge queue Aug 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants